[PATCH] D61898: Move symbol resolution code out of SymbolTable class.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/ELF/SymbolTable.cpp:605
+  case Symbol::PlaceholderKind:
+    llvm_unreachable("bad symbol type");
+  }
----------------
symbol kind?


================
Comment at: lld/ELF/Symbols.h:449
+
+inline void replaceSymbol(Symbol *Sym, const Symbol *New) {
+  using llvm::ELF::STT_TLS;
----------------
Does `const Symbol &New` work? Other add* functions use const references, e.g.

`static void addShared(Symbol *Old, const SharedSymbol &New) {`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61898/new/

https://reviews.llvm.org/D61898