[PATCH] D61897: Remove SymbolTable::addBitcode as it is redundant.

[Rui Ueyama via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rLLD360846: Pemove SymbolTable::addBitcode as it is redundant. (authored by ruiu, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D61897?vs=199424&id=199737#toc

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61897/new/

https://reviews.llvm.org/D61897

Files:
  ELF/InputFiles.cpp
  ELF/SymbolTable.cpp
  ELF/SymbolTable.h


Index: ELF/SymbolTable.cpp
===================================================================
--- ELF/SymbolTable.cpp
+++ ELF/SymbolTable.cpp
@@ -404,23 +404,6 @@
   return Old;
 }
 
-Symbol *SymbolTable::addBitcode(const Defined &New) {
-  Symbol *Old = insert(New);
-  mergeProperties(Old, New);
-
-  if (Old->isPlaceholder()) {
-    replaceSymbol(Old, &New);
-    return Old;
-  }
-
-  int Cmp = compare(Old, &New);
-  if (Cmp > 0)
-    replaceSymbol(Old, &New);
-  else if (Cmp == 0)
-    reportDuplicate(Old, New.File, nullptr, 0);
-  return Old;
-}
-
 Symbol *SymbolTable::find(StringRef Name) {
   auto It = SymMap.find(CachedHashStringRef(Name));
   if (It == SymMap.end())
Index: ELF/InputFiles.cpp
===================================================================
--- ELF/InputFiles.cpp
+++ ELF/InputFiles.cpp
@@ -1291,7 +1291,7 @@
   Defined New(&F, Name, Binding, Visibility, Type, 0, 0, nullptr);
   if (CanOmitFromDynSym)
     New.ExportDynamic = false;
-  return Symtab->addBitcode(New);
+  return Symtab->addDefined(New);
 }
 
 template <class ELFT>
Index: ELF/SymbolTable.h
===================================================================
--- ELF/SymbolTable.h
+++ ELF/SymbolTable.h
@@ -50,7 +50,6 @@
   Symbol *addShared(const SharedSymbol &New);
   Symbol *addLazyArchive(const LazyArchive &New);
   Symbol *addLazyObject(const LazyObject &New);
-  Symbol *addBitcode(const Defined &New);
   Symbol *addCommon(const CommonSymbol &New);
 
   Symbol *insert(const Symbol &New);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61897.199737.patch
Type: text/x-patch
Size: 1501 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190516/cd106582/attachment.bin>