[PATCH] D61698: [COFF] Store alignment in log2 form, NFC

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 15 16:38:26 PDT 2019


rnk added a comment.

In D61698#1502875 <https://reviews.llvm.org/D61698#1502875>, @ruiu wrote:

> By the way, the other idea I had in mind for this problem is to define a new integer-ish class that can hold only a 2^n value, by overriding cast from/to an integer. I don't know if that is a good idea or a disgusting idea, though.


Well, the next logical step, IMO, is to store the section characteristics directly in Chunk. I don't think that would work well with the custom type idea.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61698/new/

https://reviews.llvm.org/D61698





More information about the llvm-commits mailing list