[PATCH] D61690: [X86] Deduplicate symbol lowering logic, NFC

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 15 16:38:26 PDT 2019


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:17249
-  // With PIC, the address is actually $g + Offset.
-  if (OpFlag) {
-    Result =
----------------
Why was this just checking OpFlag before instead of calling isGlobalRelativeToPICBase?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61690/new/

https://reviews.llvm.org/D61690





More information about the llvm-commits mailing list