[PATCH] D61927: [tools]Introduce llvm-lipo

Michael Trent via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 15 16:04:47 PDT 2019


mtrent added inline comments.


================
Comment at: tools/llvm-lipo/llvm-lipo.cpp:96
+      if (O->getArch() != Triple(Arch).getArch())
+        reportError(Twine(O->getFileName()) + " does not contain " + Arch);
+  } else {
----------------
mtrent wrote:
> the lipo -verify_arch command does not print an error if the command is able to run successfully, as it's primarily for using with shell scripts and Makefiles. Is a verbose message really necessary here? If less, please implement a -non_verbose option.
Sigh. s/If less/If yes/;


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61927/new/

https://reviews.llvm.org/D61927





More information about the llvm-commits mailing list