[PATCH] D61870: Make cl::HideUnrelatedOptions more flexible

Don Hinton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 15 15:32:01 PDT 2019


hintonda added a comment.

In D61870#1503625 <https://reviews.llvm.org/D61870#1503625>, @hintonda wrote:

> The basic `--help-hidden` output includes a lot of additional general options, though I haven't investigated where they come from.  However, the `--help-hidden` output for a specific SubCommand does not include those options, so I'm not sure this is a problem (I'll investigate exactly how it all works and report back).  I'm temped to think SubCommands aren't really needed in this API, since only the Options for the SubCommand are printed anyway.  Again, I'll investigate and report back.


Sorry, what I meant to say was that when you print help for a SubCommand, you only get that SubCommand, so it doesn't seem to matter if the other ones are hidden or not.  Of course you still need to specify when SubCommands you don't want hidden in the first place.  In that case, SubCommand is probably the more important option as @beanz states, so it probably should come before OptionHidden.  I'm open to additional API calls as well, but they should be driven by actual use-cases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61870/new/

https://reviews.llvm.org/D61870





More information about the llvm-commits mailing list