[PATCH] D61409: [SimplifyCFG] Added condition assumption for unreachable blocks

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 15 14:09:42 PDT 2019


lebedev.ri added a comment.

In D61409#1503626 <https://reviews.llvm.org/D61409#1503626>, @nikic wrote:

> Just to be clear, I didn't mean to say that we shouldn't do this, just that it is not //guaranteed// to be a win in the end. If it's possible to do some end-to-end performance testing with this patch to make sure that it doesn't come with unexpected regressions, I see no reason not to move forward with this change. The problem with assumes is a long-standing one and I don't think it has any simple solution.


That was my take, too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61409/new/

https://reviews.llvm.org/D61409





More information about the llvm-commits mailing list