[PATCH] D61870: Make cl::HideUnrelatedOptions more flexible

[serge via Phabricator via llvm-commits]

serge-sans-paille added a comment.

@beanz

> I expect that we will want to use cl::HideUnrelatedOptions in a lot more places to clean up other tool help messages.

That's indeed the plan.

> That makes me a little more concerned about the API and not having a clear picture of the use cases I'm not sure this is correct.
>  In particular I think the common case may be setting cl::ReallyHidden (I see no example otherwise), which means as soon as we start applying this tool to tools with subcommands the API gets messy.

As pointed out by @hintonda, current default argument is *never* explicitly used in the codebase. Concerning the tools, I plan to either set `cl::ReallyHidden ` for simple tools like `llvm-cat`, or `cl::Hidden` for tools where extra options may matter but would clutter the -help output. `llvm-as` (see https://reviews.llvm.org/D60603) is one of those.

This may also mean that each option should have a category, but I'm unsure.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61870/new/

https://reviews.llvm.org/D61870