[PATCH] D61870: Make cl::HideUnrelatedOptions more flexible

[Don Hinton via Phabricator via llvm-commits]

hintonda accepted this revision.
hintonda added a comment.
This revision is now accepted and ready to land.

Just a couple nits, otherwise looks great.

LGTM, but please give it a day for any further comments.



================
Comment at: llvm/include/llvm/Support/CommandLine.h:1974
+/// \param Category the category of options to keep displaying.
+/// \param Opt the flag to apply to all other categories.
 ///
----------------
Could you document the 3rd parameter as well? Here and below.


================
Comment at: llvm/include/llvm/Support/CommandLine.h:1980
 void HideUnrelatedOptions(cl::OptionCategory &Category,
+                          cl::OptionHidden Opt = cl::ReallyHidden,
                           SubCommand &Sub = *TopLevelSubCommand);
----------------
Please change the name of this parameter, here and elsewhere, to indicate it's a flag, not an Option.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61870/new/

https://reviews.llvm.org/D61870