[PATCH] D61895: Introduce CommonSymbol.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 15 06:53:49 PDT 2019
MaskRay accepted this revision.
MaskRay added inline comments.
================
Comment at: lld/ELF/Driver.cpp:1697
+ // Replace common symbols with regular symbols.
+ replaceCommonSymbols();
----------------
regular defined symbols?
================
Comment at: lld/ELF/Symbols.h:238
+//
+// On Unix, it is traditionally allowed to write variable definitions
+// without initialization expressions (such as "int foo;") to header
----------------
The comment may mention this is for C tentative definitions (its origin is Fortran COMMON blocks, which may predate Unix...)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61895/new/
https://reviews.llvm.org/D61895
More information about the llvm-commits
mailing list