[PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

Wed May 15 02:16:05 PDT 2019

labath added a comment.

In D61713#1502617 <https://reviews.llvm.org/D61713#1502617>, @mgorny wrote:

> In D61713#1502606 <https://reviews.llvm.org/D61713#1502606>, @labath wrote:
>
> > In D61713#1502580 <https://reviews.llvm.org/D61713#1502580>, @mgorny wrote:
> >
> > > Is this test supposed to work portably? It fails on NetBSD buildbot: http://lab.llvm.org:8011/builders/netbsd-amd64/builds/20101/steps/run%20unit%20tests/logs/FAIL%3A%20LLDB%3A%3Acompiler-full-path.test
> >
> >
> > I think we can just add --mode=link to the test to avoid it trying to mess with the linker (since that is not important here anyway).
>
>
> Did you mean `--mode=compile`? I can confirm it fixes the test. Should I commit it?

Yes, that's what I meant. :) Feel free to commit.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61713/new/

https://reviews.llvm.org/D61713