[PATCH] D61563: [ELF] Error on relocations to local undefined symbols

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan added a comment.

I do not remember a reason of adding the `.reloc 0, R_MIPS_GOT_PAGE, 0` statement to the test. I think now we can change `mips-abs-got.s` like that:

  --- a/lld/test/ELF/mips-abs-got.s
  +++ b/lld/test/ELF/mips-abs-got.s
  @@ -4,7 +4,7 @@
   
   # RUN: llvm-mc -filetype=obj -triple=mips64-unknown-linux -o %t.o %s
   # RUN: echo "SECTIONS { \
  -# RUN:          zero = 0; foo = 0x11004; bar = 0x22000; }" > %t.script
  +# RUN:          zero1 = 0; zero2 = 0; foo = 0x11004; bar = 0x22000; }" > %t.script
   # RUN: ld.lld --script %t.script -o %t.exe %t.o
   # RUN: llvm-readobj --mips-plt-got %t.exe | FileCheck %s
   
  @@ -30,7 +30,7 @@
   
     .text
     nop
  -  .reloc 0, R_MIPS_GOT_PAGE, 0
  -  ld      $v0, %got_page(zero)($gp)
  +  ld      $v0, %got_page(zero1)($gp)
  +  ld      $v0, %got_page(zero2)($gp)
     ld      $v0, %got_page(foo)($gp)
     ld      $v0, %got_page(bar+0x10008)($gp)


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61563/new/

https://reviews.llvm.org/D61563