[PATCH] D61902: [AArch64][SVE2] Asm: add unpredicated integer multiply instructions

[Diana Picus via Phabricator via llvm-commits]

rovka accepted this revision.
rovka added a comment.

LGTM with minor nits.



================
Comment at: test/MC/AArch64/SVE2/mul-diagnostics.s:57
+// ------------------------------------------------------------------------- //
+// Invalid element width
+
----------------
Nitpick: Add a test with all registers .b (ditto for sqdmulh and sqrdmulh).


================
Comment at: test/MC/AArch64/SVE2/sqdmulh-diagnostics.s:57
+// ------------------------------------------------------------------------- //
+// Invalid element width
+
----------------
Nitpick: These are all for the indexed form, maybe you should have some for the unindexed version as well (like the ones for e.g. umulh)? Ditto for sqrdmulh.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61902/new/

https://reviews.llvm.org/D61902