[PATCH] D61855: Simplify SymbolTable::add{Defined,Undefined,...} functions.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/SymbolTable.cpp:121
+
+    Old->SymbolKind = Symbol::PlaceholderKind;
+    Old->VersionId = Config->DefaultSymbolVersion;
----------------
It seems after every `insert()` call, if the `IsNew` branch is taken, these member variables are initialized then get overridden by `replaceSymbol(Old, New)`. Is there some way to prevent repeated assignments?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61855/new/

https://reviews.llvm.org/D61855