[PATCH] D61924: [WebAssembly] LTO: Honor comdat groups when loading bitcode files

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

In D61924#1502458 <https://reviews.llvm.org/D61924#1502458>, @ruiu wrote:

> Even though what this code does is the same as what we do for the ELF linker, the code looks different. In ELF, we pass ComdatGroups (which is a set of comdat signature strings we've seen so far) around. I don't remember if there was a reason to do it differently for Wasm. Do you remmeber?


I found this version more explicit.   ELF currently passes a new `DummyGroups` to each LTO object's parse function as way of implicitly disabling comdats, but I think explicitly disabling them improves clarity.   Perhaps I should change the ELF linker to do the same thing either in this change or as a followup?  Alternaitvely I would update this PR to match the ELF method and propose a separate PR to convert them both over as a followup?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61924/new/

https://reviews.llvm.org/D61924