[PATCH] D61532: implement of the parsing symbol table for xcoffobjfile and output as yaml format

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 14 19:11:09 PDT 2019


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/test/tools/obj2yaml/aix_xcoff.test:17
+# CHECK-NEXT:     Section: N_DEBUG
+# CHECK-NEXT:     Type:      0x0003
+# CHECK-NEXT:     StorageClass:    C_FILE
----------------
The question for this line is whether printing as a single type field is appropriate. This is a `C_FILE` entry where `n_lang` is `C (0x00)` and `n_cputype` is `COM (0x03)`. That is, perhaps we should have inspected `CFileLanguageIdAndTypeId`?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61532/new/

https://reviews.llvm.org/D61532





More information about the llvm-commits mailing list