[PATCH] D60935: [IndVarSimplify] Fixup nowrap flags during LFTR when moving to post-inc (PR31181)

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 14 16:10:44 PDT 2019


reames added a comment.

Reading through the discussion, it sounds like the only place where LFTR goes wrong is dealing with the post-increment form of the IV right?

If so, what about splitting LFTR into two parts.  The first part does LFTR *without changing pre-to-post or vice versa*, and then a second part which converts to post-increment where possible.  The value of the later seems quite questionable to me honestly, and if we have to restrict it greatly it wouldn't matter as much as having to restrict the first part.    I'd also really like to be able to extend the first part to multiple exit loops whereas extending the second part seems actively harmful on some examples.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60935/new/

https://reviews.llvm.org/D60935





More information about the llvm-commits mailing list