[PATCH] D59065: Add ptrmask intrinsic

Tue May 14 11:59:50 PDT 2019

hfinkel added a comment.

> I don't see why but I might be wrong (@hfinkel). What I thought is detailed below.

I think that the current wording looks good, and does include a statement that the new pointer is based on the same underlying object as the old pointer. Do you have any remaining concerns?

================
Comment at: llvm/docs/LangRef.rst:16469
+integer (ptrtoint/inttoptr). As a consequence, we can preserve more information
+to facilitate alias analysis and underlying object detection.
+
----------------
underlying-object detected [dash for a compound adjective].

================
Comment at: llvm/docs/LangRef.rst:16477
+pointer and the first argument are based on the same underlying object (for more
+information on the *based* on terminology see
+:ref:`the pointer aliasing rules <pointeraliasing>`). If the bitwidth of the
----------------
*based on* [the term is "based on"].

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59065/new/

https://reviews.llvm.org/D59065