[PATCH] D61794: [LVI][CVP] Add support for abs/nabs select pattern flavor
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 14 11:51:21 PDT 2019
This revision was automatically updated to reflect the committed changes.
Closed by commit rL360700: [LVI][CVP] Add support for abs/nabs select pattern flavor (authored by nikic, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D61794?vs=199035&id=199488#toc
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61794/new/
https://reviews.llvm.org/D61794
Files:
llvm/trunk/lib/Analysis/LazyValueInfo.cpp
llvm/trunk/test/Transforms/CorrelatedValuePropagation/basic.ll
Index: llvm/trunk/lib/Analysis/LazyValueInfo.cpp
===================================================================
--- llvm/trunk/lib/Analysis/LazyValueInfo.cpp
+++ llvm/trunk/lib/Analysis/LazyValueInfo.cpp
@@ -893,7 +893,28 @@
return true;
}
- // TODO: ABS, NABS from the SelectPatternResult
+ if (SPR.Flavor == SPF_ABS) {
+ if (LHS == SI->getTrueValue()) {
+ BBLV = ValueLatticeElement::getRange(TrueCR.abs());
+ return true;
+ }
+ if (LHS == SI->getFalseValue()) {
+ BBLV = ValueLatticeElement::getRange(FalseCR.abs());
+ return true;
+ }
+ }
+
+ if (SPR.Flavor == SPF_NABS) {
+ ConstantRange Zero(APInt::getNullValue(TrueCR.getBitWidth()));
+ if (LHS == SI->getTrueValue()) {
+ BBLV = ValueLatticeElement::getRange(Zero.sub(TrueCR.abs()));
+ return true;
+ }
+ if (LHS == SI->getFalseValue()) {
+ BBLV = ValueLatticeElement::getRange(Zero.sub(FalseCR.abs()));
+ return true;
+ }
+ }
}
// Can we constrain the facts about the true and false values by using the
Index: llvm/trunk/test/Transforms/CorrelatedValuePropagation/basic.ll
===================================================================
--- llvm/trunk/test/Transforms/CorrelatedValuePropagation/basic.ll
+++ llvm/trunk/test/Transforms/CorrelatedValuePropagation/basic.ll
@@ -633,8 +633,7 @@
; CHECK-NEXT: store i1 true, i1* [[P:%.*]]
; CHECK-NEXT: [[C2:%.*]] = icmp slt i32 [[ABS]], 19
; CHECK-NEXT: store i1 [[C2]], i1* [[P]]
-; CHECK-NEXT: [[C3:%.*]] = icmp sge i32 [[ABS]], 0
-; CHECK-NEXT: store i1 [[C3]], i1* [[P]]
+; CHECK-NEXT: store i1 true, i1* [[P]]
; CHECK-NEXT: [[C4:%.*]] = icmp sge i32 [[ABS]], 1
; CHECK-NEXT: store i1 [[C4]], i1* [[P]]
; CHECK-NEXT: br label [[EXIT]]
@@ -684,8 +683,7 @@
; CHECK-NEXT: store i1 true, i1* [[P:%.*]]
; CHECK-NEXT: [[C2:%.*]] = icmp slt i32 [[ABS]], 19
; CHECK-NEXT: store i1 [[C2]], i1* [[P]]
-; CHECK-NEXT: [[C3:%.*]] = icmp sge i32 [[ABS]], 0
-; CHECK-NEXT: store i1 [[C3]], i1* [[P]]
+; CHECK-NEXT: store i1 true, i1* [[P]]
; CHECK-NEXT: [[C4:%.*]] = icmp sge i32 [[ABS]], 1
; CHECK-NEXT: store i1 [[C4]], i1* [[P]]
; CHECK-NEXT: br label [[EXIT]]
@@ -735,8 +733,7 @@
; CHECK-NEXT: store i1 true, i1* [[P:%.*]]
; CHECK-NEXT: [[C2:%.*]] = icmp sgt i32 [[NABS]], -19
; CHECK-NEXT: store i1 [[C2]], i1* [[P]]
-; CHECK-NEXT: [[C3:%.*]] = icmp sle i32 [[NABS]], 0
-; CHECK-NEXT: store i1 [[C3]], i1* [[P]]
+; CHECK-NEXT: store i1 true, i1* [[P]]
; CHECK-NEXT: [[C4:%.*]] = icmp sle i32 [[NABS]], -1
; CHECK-NEXT: store i1 [[C4]], i1* [[P]]
; CHECK-NEXT: br label [[EXIT]]
@@ -786,8 +783,7 @@
; CHECK-NEXT: store i1 true, i1* [[P:%.*]]
; CHECK-NEXT: [[C2:%.*]] = icmp sgt i32 [[NABS]], -19
; CHECK-NEXT: store i1 [[C2]], i1* [[P]]
-; CHECK-NEXT: [[C3:%.*]] = icmp sle i32 [[NABS]], 0
-; CHECK-NEXT: store i1 [[C3]], i1* [[P]]
+; CHECK-NEXT: store i1 true, i1* [[P]]
; CHECK-NEXT: [[C4:%.*]] = icmp sle i32 [[NABS]], -1
; CHECK-NEXT: store i1 [[C4]], i1* [[P]]
; CHECK-NEXT: br label [[EXIT]]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61794.199488.patch
Type: text/x-patch
Size: 3174 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190514/ec509ac8/attachment.bin>
More information about the llvm-commits
mailing list