[llvm] r360700 - [LVI][CVP] Add support for abs/nabs select pattern flavor

[Nikita Popov via llvm-commits]

Author: nikic
Date: Tue May 14 11:53:47 2019
New Revision: 360700

URL: http://llvm.org/viewvc/llvm-project?rev=360700&view=rev
Log:
[LVI][CVP] Add support for abs/nabs select pattern flavor

Based on ConstantRange support added in D61084, we can now handle
abs and nabs select pattern flavors in LVI.

Differential Revision: https://reviews.llvm.org/D61794

Modified:
    llvm/trunk/lib/Analysis/LazyValueInfo.cpp
    llvm/trunk/test/Transforms/CorrelatedValuePropagation/basic.ll

Modified: llvm/trunk/lib/Analysis/LazyValueInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/LazyValueInfo.cpp?rev=360700&r1=360699&r2=360700&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/LazyValueInfo.cpp (original)
+++ llvm/trunk/lib/Analysis/LazyValueInfo.cpp Tue May 14 11:53:47 2019
@@ -893,7 +893,28 @@ bool LazyValueInfoImpl::solveBlockValueS
       return true;
     }
 
-    // TODO: ABS, NABS from the SelectPatternResult
+    if (SPR.Flavor == SPF_ABS) {
+      if (LHS == SI->getTrueValue()) {
+        BBLV = ValueLatticeElement::getRange(TrueCR.abs());
+        return true;
+      }
+      if (LHS == SI->getFalseValue()) {
+        BBLV = ValueLatticeElement::getRange(FalseCR.abs());
+        return true;
+      }
+    }
+
+    if (SPR.Flavor == SPF_NABS) {
+      ConstantRange Zero(APInt::getNullValue(TrueCR.getBitWidth()));
+      if (LHS == SI->getTrueValue()) {
+        BBLV = ValueLatticeElement::getRange(Zero.sub(TrueCR.abs()));
+        return true;
+      }
+      if (LHS == SI->getFalseValue()) {
+        BBLV = ValueLatticeElement::getRange(Zero.sub(FalseCR.abs()));
+        return true;
+      }
+    }
   }
 
   // Can we constrain the facts about the true and false values by using the

Modified: llvm/trunk/test/Transforms/CorrelatedValuePropagation/basic.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/CorrelatedValuePropagation/basic.ll?rev=360700&r1=360699&r2=360700&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/CorrelatedValuePropagation/basic.ll (original)
+++ llvm/trunk/test/Transforms/CorrelatedValuePropagation/basic.ll Tue May 14 11:53:47 2019
@@ -633,8 +633,7 @@ define void @abs1(i32 %a, i1* %p) {
 ; CHECK-NEXT:    store i1 true, i1* [[P:%.*]]
 ; CHECK-NEXT:    [[C2:%.*]] = icmp slt i32 [[ABS]], 19
 ; CHECK-NEXT:    store i1 [[C2]], i1* [[P]]
-; CHECK-NEXT:    [[C3:%.*]] = icmp sge i32 [[ABS]], 0
-; CHECK-NEXT:    store i1 [[C3]], i1* [[P]]
+; CHECK-NEXT:    store i1 true, i1* [[P]]
 ; CHECK-NEXT:    [[C4:%.*]] = icmp sge i32 [[ABS]], 1
 ; CHECK-NEXT:    store i1 [[C4]], i1* [[P]]
 ; CHECK-NEXT:    br label [[EXIT]]
@@ -684,8 +683,7 @@ define void @abs2(i32 %a, i1* %p) {
 ; CHECK-NEXT:    store i1 true, i1* [[P:%.*]]
 ; CHECK-NEXT:    [[C2:%.*]] = icmp slt i32 [[ABS]], 19
 ; CHECK-NEXT:    store i1 [[C2]], i1* [[P]]
-; CHECK-NEXT:    [[C3:%.*]] = icmp sge i32 [[ABS]], 0
-; CHECK-NEXT:    store i1 [[C3]], i1* [[P]]
+; CHECK-NEXT:    store i1 true, i1* [[P]]
 ; CHECK-NEXT:    [[C4:%.*]] = icmp sge i32 [[ABS]], 1
 ; CHECK-NEXT:    store i1 [[C4]], i1* [[P]]
 ; CHECK-NEXT:    br label [[EXIT]]
@@ -735,8 +733,7 @@ define void @nabs1(i32 %a, i1* %p) {
 ; CHECK-NEXT:    store i1 true, i1* [[P:%.*]]
 ; CHECK-NEXT:    [[C2:%.*]] = icmp sgt i32 [[NABS]], -19
 ; CHECK-NEXT:    store i1 [[C2]], i1* [[P]]
-; CHECK-NEXT:    [[C3:%.*]] = icmp sle i32 [[NABS]], 0
-; CHECK-NEXT:    store i1 [[C3]], i1* [[P]]
+; CHECK-NEXT:    store i1 true, i1* [[P]]
 ; CHECK-NEXT:    [[C4:%.*]] = icmp sle i32 [[NABS]], -1
 ; CHECK-NEXT:    store i1 [[C4]], i1* [[P]]
 ; CHECK-NEXT:    br label [[EXIT]]
@@ -786,8 +783,7 @@ define void @nabs2(i32 %a, i1* %p) {
 ; CHECK-NEXT:    store i1 true, i1* [[P:%.*]]
 ; CHECK-NEXT:    [[C2:%.*]] = icmp sgt i32 [[NABS]], -19
 ; CHECK-NEXT:    store i1 [[C2]], i1* [[P]]
-; CHECK-NEXT:    [[C3:%.*]] = icmp sle i32 [[NABS]], 0
-; CHECK-NEXT:    store i1 [[C3]], i1* [[P]]
+; CHECK-NEXT:    store i1 true, i1* [[P]]
 ; CHECK-NEXT:    [[C4:%.*]] = icmp sle i32 [[NABS]], -1
 ; CHECK-NEXT:    store i1 [[C4]], i1* [[P]]
 ; CHECK-NEXT:    br label [[EXIT]]