[PATCH] D61326: Fixes for builds that require strict X/Open and POSIX compatiblity

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Support/Unix/Path.inc:156
     return nullptr;
-  s = pv = strdup(pv);
-  if (!pv)
+  char *s= strdup(pv);
+  if (!s)
----------------
Minor nit: Add a space before the `=`.


================
Comment at: llvm/lib/Support/Unix/Path.inc:160
+  char *state;
+  if ((char *t = strtok_r(s, ":", &state)) != nullptr) {
+    do {
----------------
Does this compile?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61326/new/

https://reviews.llvm.org/D61326