[PATCH] D60457: [CodeGen] Fixed de-optimization of legalize subvector extract

Tue May 14 08:09:23 PDT 2019

tpr marked 2 inline comments as done.
tpr added inline comments.

================
Comment at: test/CodeGen/AMDGPU/extract_subvector_vec4_vec3.ll:4
+; GCN-LABEL: body:
+; GCN-NOT: %stack
+
----------------
nhaehnle wrote:
> tpr wrote:
> > nhaehnle wrote:
> > > tpr wrote:
> > > > arsenm wrote:
> > > > > I wouldn’t trust this to check this, a generated check would be better
> > > > Not really sure what you're suggesting, but I hope this is better.
> > > Maybe you can use `util/update_llc_test_checks.py`?
> > You mean have a check line for each line of IR output in the function? Do you think that would be better than the negative check for storing to stack?
> Yes, I do think so. Having the auto-generated assertions means that we catch other things going wrong, and it's easy enough to update them for benign changes.
> 
> I realize that you actually need update_mir_test_checks in this case due to the -stop-after, and the script is sensitive to the fact that there's no space between the `<` and the `%s`.
Thanks Nicolai. Now done.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60457/new/

https://reviews.llvm.org/D60457