[PATCH] D61856: [test]Make test work on Windows

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 14 08:06:43 PDT 2019


MaskRay added inline comments.


================
Comment at: test/tools/llvm-objdump/X86/source-interleave-x86_64.ll:1
-;  REQUIRES: shell
-;  RUN: sed -e "s,SRC_COMPDIR,%p/Inputs,g" %s > %t.ll
+;  RUN: sed -e "s,SRC_COMPDIR,%/p/Inputs,g" %s > %t.ll
 ;  RUN: llc  -o %t.o -filetype=obj -mtriple=x86_64-pc-linux  %t.ll
----------------
jhenderson wrote:
> MaskRay wrote:
> > Use single quotes? BTW, I'm curious what backslashes in single quotes do (in the expanded `sed -e 's,SRC_COMPDIR,%p/Inputs,g'`) do on Windows...
> I've not done this. Double-quotes work fine and are what were there before.
It's fine. I was asking because in POSIX sh the backslash in single quotes wouldn't cause issues.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61856/new/

https://reviews.llvm.org/D61856





More information about the llvm-commits mailing list