[PATCH] D61899: [Mips] LLVM and GAS now use same instructions for CFA Definition. NFCI

[Mirko Brkusanin via Phabricator via llvm-commits]

mbrkusanin added a comment.

It seems that using the instruction without offset does not affect exception 
handling. Testing it on a couple of simple examples where unwinding the stack 
is necessary gives correct output. This is expected since GAS uses the same 
instructions. Documentation does not indicate that there are any differences 
between these two instructions if we don't change the offset (in code before the
patch value passed was +0). This patch may be unnecessary but if we want to be 
sure that there aren't any unexpected problems down the line we could apply it.

Now in .eh_frame instead of:

  DW_CFA_def_cfa: reg29 +0

we have:

  DW_CFA_def_cfa_register: reg29
  DW_CFA_nop:

DW_CFA_nop is used for padding since DW_CFA_def_cfa_register is shorter (has one
less operand).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61899/new/

https://reviews.llvm.org/D61899