[PATCH] D61830: [X86][SSE] Disable shouldFoldConstantShiftPairToMask for scalar shifts on AMD targets (PR40758)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 14 02:19:19 PDT 2019


lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

LG
I'm not sure why `[SSE]` tag is in the subject, should it be `[AMD]`?

Also, do we want to unfold `and (shift x, c1), c2` / `shift (and x, c1), c2` ?
Not sure, under `!TLI.shouldFoldConstantShiftPairToMask()` or a new `shouldFoldMaskToConstantShiftPair()`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61830/new/

https://reviews.llvm.org/D61830





More information about the llvm-commits mailing list