[PATCH] D61857: [LTO] Improve readability of module IDs

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

My minor concern is that the new message is a bit inconsistent with our other error messages I think.

For example, we have:
{{.*}}.a({{.*}}.o): corrupted ELF file: invalid data encoding

i.e. it is <archive name>(<object name>)

and in your message you have different format:

<archive name>:<offset>(<object name>)

So I would suggest to make it <archive name>(<object name> at <offset>) or <archive name>(<object name>:<offset>) probably.

I think Rui might have a opinion here about how the error message should look like.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61857/new/

https://reviews.llvm.org/D61857