[PATCH] D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation

[Yvan Roux via llvm-commits]

Hi Petr,

This patch broke ARM bots, because of an undefined reference to symbol
'__aeabi_unwind_cpp_pr0@@GCC_3.5', notice that on ARM this symbol is
not defined in libgcc but in libgcc_eh.  Logs of the last build issue
are available here:

http://lab.llvm.org:8011/builders/clang-cmake-armv7-full/builds/6098/steps/ninja%20check%201/logs/FAIL%3A%20CRT-armhf-linux%3A%3A%20dso_handle.cpp

Thanks
Yvan

On Fri, 10 May 2019 at 16:13, Nico Weber via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:
>
> thakis added inline comments.
>
>
> ================
> Comment at: compiler-rt/trunk/lib/crt/crtbegin.c:7
> +//
> +//===----------------------------------------------------------------------===//
> +
> ----------------
> gcc warns about this:
>
> ```
> /b/swarming/w/ir/k/src/third_party/llvm/projects/compiler-rt/lib/crt/crtend.c:1:1: warning: C++ style comments are not allowed in ISO C90 [enabled by default]
> ```
>
> Could we either use /**/ comments or pass -std=c99 for this file?
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D28791/new/
>
> https://reviews.llvm.org/D28791
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits