[PATCH] D61117: Fix Bug 41353 - unique symbols printed as D instead of u

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 14 01:40:20 PDT 2019


jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-nm/X86/unique.test:6
+FileHeader:      
+  Class:           ELFCLASS64
+  Data:            ELFDATA2LSB
----------------
Nit: there's no need to add large numbers of spaces between the tag and value in the YAML. Just add enough so that all values in a block line up:

```
  Class:   ELFCLASS64
  Data:    ELFDATA2LSB
  Type:    ET_REL
  Machine: EM_X86_64
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61117/new/

https://reviews.llvm.org/D61117





More information about the llvm-commits mailing list