[PATCH] D60385: FileCheck [5/12]: Introduce regular numeric variables

Tue May 14 01:24:32 PDT 2019

jhenderson added a comment.

In D60385#1500037 <https://reviews.llvm.org/D60385#1500037>, @thopre wrote:

> In D60385#1499921 <https://reviews.llvm.org/D60385#1499921>, @thopre wrote:
>
> > In D60385#1499819 <https://reviews.llvm.org/D60385#1499819>, @thopre wrote:
> >
> > > In D60385#1499812 <https://reviews.llvm.org/D60385#1499812>, @jhenderson wrote:
> > >
> > > > Okay, LGTM, but make sure @probinson is happy at least.
> > >
> > >
> > > He wrote "I am pretty happy with this now, maybe give the other people who have been participating a day or so to chime in again" earlier so will commit this now. Thanks everyone who has tirelessly reviewed this patch! It's good to get the first big patch adding support for numeric expression landing.
> >
> >
> > FYI I've noticed the sphinx error in [1] and am investigated it. I changed laptop recently and sphinx build was not enabled on the new one which is why I missed it. Am doing a build now with sphinx enabled and will send a patch as soon as I can reproduce the issue.
> >
> > [1] http://lab.llvm.org:8011/builders/llvm-sphinx-docs/builds/31133/steps/docs-llvm-html/logs/stdio
>
>
> I'm afraid I cannot reproduce this error. I'm using sphinx-build 1.8.5 from the python-sphinx Ubuntu package version 1.6.7-1ubuntu1. Can anyone with a different version try to reproduce? Thanks in advance.

I don't have Sphinx setup on my machine. I'd suggest a couple of things: 1) make sure that the problem was directly caused by your change according to the build bots, and isn't a case of flakiness. 2) Ask for help on the llvm-dev mailing list, CC'ing the build bot maintainer who may be able to better reproduce. You should (unfortunately) probably also revert if you haven't so that the build bots aren't bad for everyone else's changes.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60385/new/

https://reviews.llvm.org/D60385