[PATCH] D61870: Have cl::HideUnrelatedOptions just Hide and not ReallyHide options
Don Hinton via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 13 22:42:15 PDT 2019
hintonda added a comment.
In D61870#1500834 <https://reviews.llvm.org/D61870#1500834>, @serge-sans-paille wrote:
> > It was added in D7100 <https://reviews.llvm.org/D7100>, and I think the rational was to hide implementation details.
>
> @hintonda: What about an optional ``bool ReallyHide=true`` paramer so that the same function could be use to really hide or just hide?
Yes, that's what I was trying to say, but since it's an enum, I'd rather you use the real type. Just set the default to `ReallyHidden` to maintain current behavior. Then you can just pass it to `cl::setHiddenFlag()` and be done with it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61870/new/
https://reviews.llvm.org/D61870
More information about the llvm-commits
mailing list