[PATCH] D61819: gn build: add Hexagon target
David L. Jones via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 13 21:11:44 PDT 2019
dlj added a comment.
In D61819#1500150 <https://reviews.llvm.org/D61819#1500150>, @thakis wrote:
> Like with the Lanai target: lgtm with the usual two comments (1. https://reviews.llvm.org/D61859 treatment for MCTargetDesc;
Done, to satisfy:
llvm/lib/Target/Hexagon/HexagonInstrInfo.h:#include "HexagonGenInstrInfo.inc"
llvm/lib/Target/Hexagon/HexagonISelDAGToDAG.h: #include "HexagonGenDAGISel.inc"
llvm/lib/Target/Hexagon/HexagonRegisterInfo.h:#include "HexagonGenRegisterInfo.inc"
llvm/lib/Target/Hexagon/HexagonSubtarget.h:#include "HexagonGenSubtargetInfo.inc"
llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCTargetDesc.h:#include "HexagonGenRegisterInfo.inc"
llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCTargetDesc.h:#include "HexagonGenInstrInfo.inc"
llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCTargetDesc.h:#include "HexagonGenSubtargetInfo.inc"
> 2. Consider omitting unused llvm_build_Hexago variable)
Done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61819/new/
https://reviews.llvm.org/D61819
More information about the llvm-commits
mailing list