[PATCH] D61818: gn build: add Lanai target

David L. Jones via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 13 20:49:35 PDT 2019


dlj added a comment.

In D61818#1500147 <https://reviews.llvm.org/D61818#1500147>, @thakis wrote:

> lgtm with the usual two comments (1. https://reviews.llvm.org/D61859 treatment for MCTargetDesc;


Done. FTR:

llvm/lib/Target/Lanai/LanaiInstrInfo.h:#include "LanaiGenInstrInfo.inc"
llvm/lib/Target/Lanai/LanaiRegisterInfo.h:#include "LanaiGenRegisterInfo.inc"
llvm/lib/Target/Lanai/LanaiSubtarget.h:#include "LanaiGenSubtargetInfo.inc"
llvm/lib/Target/Lanai/MCTargetDesc/LanaiMCTargetDesc.h:#include "LanaiGenRegisterInfo.inc"
llvm/lib/Target/Lanai/MCTargetDesc/LanaiMCTargetDesc.h:#include "LanaiGenInstrInfo.inc"
llvm/lib/Target/Lanai/MCTargetDesc/LanaiMCTargetDesc.h:#include "LanaiGenSubtargetInfo.inc"

This matches the behavior for most other Target libraries in D61859 <https://reviews.llvm.org/D61859>.

> 2. Consider omitting unused llvm_build_Lanai variable)

Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61818/new/

https://reviews.llvm.org/D61818





More information about the llvm-commits mailing list