[PATCH] D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 13 16:23:40 PDT 2019


sbc100 marked an inline comment as done.
sbc100 added inline comments.


================
Comment at: lld/wasm/SyntheticSections.h:318
+
+extern InStruct In;
+
----------------
I was wondering about the naming of this struct and global.

In ELF I think "In" might mean "Input" since there the synthetic sections are input sections.  However we currently use OutputSections, so this name make less sense.

Perhaps I should call these "OutStruct" and "Out" or "Synth" perhaps?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61811/new/

https://reviews.llvm.org/D61811





More information about the llvm-commits mailing list