[PATCH] D61870: Have cl::HideUnrelatedOptions just Hide and not ReallyHide options

Don Hinton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 13 14:56:58 PDT 2019


hintonda added a comment.

In D61870#1500560 <https://reviews.llvm.org/D61870#1500560>, @hintonda wrote:

> In D61870#1500546 <https://reviews.llvm.org/D61870#1500546>, @lebedev.ri wrote:
>
> > Thanks! I do like the `llvm-cat -help` changes, and this does make sense in that context.
> >  @hintonda can you comment on why the lhs of the diff is the way it is, why these were `cl::ReallyHidden`?
>
>
> It was added in D7100 <https://reviews.llvm.org/D7100>, and I think the rational was to hide implementation details.


Btw, here's a quick one liner for finding this stuff:

  git log `git blame llvm/unittests/Support/CommandLineTest.cpp | grep " 383)" |cut -d ' ' -f 1`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61870/new/

https://reviews.llvm.org/D61870





More information about the llvm-commits mailing list