[PATCH] D61870: Have cl::HideUnrelatedOptions just Hide and not ReallyHide options

[Don Hinton via Phabricator via llvm-commits]

hintonda requested changes to this revision.
hintonda added a comment.
This revision now requires changes to proceed.

This is a great idea, but I'd prefer it not unilaterally change current behavior.



================
Comment at: llvm/lib/Support/CommandLine.cpp:2430
           Cat != &GenericCategory)
-        I.second->setHiddenFlag(cl::ReallyHidden);
+        I.second->setHiddenFlag(cl::Hidden);
     }
----------------
I think it would be better to default to the current behavior and add an additional default parameter to `cl::HideUnrelatedOptions`.   That way, anyone using this options will continue to get the same behavior, while allowing others to pass `cl::Hidden` if they don't want them really hidden.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61870/new/

https://reviews.llvm.org/D61870