[PATCH] D61150: [SimplifyCFG] NFC, update Switch tests to HEAD so I can see if my changes change anything
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 13 12:58:23 PDT 2019
nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.
A few last issues...
================
Comment at: test/Transforms/SimplifyCFG/switch-dead-default.ll:246
; CHECK-LABEL: @test8(
-; CHECK: switch i8
+; CHECK-NEXT: unreachable
+;
----------------
This seems odd. Are you sure these are the results without any other patches?
================
Comment at: test/Transforms/SimplifyCFG/switch-on-const-select.ll:158
; CHECK: attributes [[$NUW]] = { nounwind }
; CHECK: attributes #1 = { cold noreturn nounwind }
----------------
Does this test actually pass after being regenerated? I'd expect an error due to the undefined variable here. This probably needs to be replaced with just `#0` if you're using it above.
================
Comment at: test/Transforms/SimplifyCFG/switch_create-custom-dl.ll:763
; CHECK-NOT: switch
; CHECK: ret void
define void @test20(i32 %arg) {
----------------
More leftovers.
================
Comment at: test/Transforms/SimplifyCFG/switch_create.ll:739
; CHECK: %or.cond1 = and i1 %cmp17, %or.cond
; CHECK: br i1 %or.cond1, label %if.end29, label %if.then27
----------------
A few more left here...
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61150/new/
https://reviews.llvm.org/D61150
More information about the llvm-commits
mailing list