[PATCH] Fix Bugzilla ID 41862 to support checking addresses of disassembled object

Roman Lebedev via llvm-commits llvm-commits at lists.llvm.org
Mon May 13 12:19:55 PDT 2019


Best to upload the patch to phabricator, and add a test

On Mon, May 13, 2019 at 10:12 PM Nicholas Krause via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
> This fixes the bugzilla id,41862 to support dealing with checking
> stop address against start address to support this not being a
> proper object to check the disasembly against like gnu objdump
> currently does.
>
> Signed-off-by: Nicholas Krause <xerofoify at gmail.com>
> ---
>  llvm/tools/llvm-objdump/llvm-objdump.cpp | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/llvm/tools/llvm-objdump/llvm-objdump.cpp b/llvm/tools/llvm-objdump/llvm-objdump.cpp
> index 3fddfd2d349..ee37549cc05 100644
> --- a/llvm/tools/llvm-objdump/llvm-objdump.cpp
> +++ b/llvm/tools/llvm-objdump/llvm-objdump.cpp
> @@ -1376,6 +1376,8 @@ static void disassembleObject(const Target *TheTarget, const ObjectFile *Obj,
>  static void disassembleObject(const ObjectFile *Obj, bool InlineRelocs) {
>    if (StartAddress > StopAddress)
>      error("Start address should be less than stop address");
> +  else if (StartAddress == StopAddress)
> +    error("Start address should not be equal to  target object's stop address");
>
>    const Target *TheTarget = getTarget(Obj);
>
> --
> 2.20.1
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list