[PATCH] D61613: [LLD][ELF] Add the -z ifunc-noplt option

[Mark Johnston via Phabricator via llvm-commits]

markj added inline comments.


================
Comment at: lld/test/ELF/gnu-ifunc-noplt.s:4
+// RUN: ld.lld %t1.o --shared -o %t.so
+// RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-freebsd %s -o %t.o
+// RUN: ld.lld -z ifunc-noplt -z notext --hash-style=sysv %t.so %t.o -o %tout
----------------
MaskRay wrote:
> `x86_64-unknown-freebsd` and `x86_64-pc-freebsd` do the same thing but it might be worth keeping consistency in the same file :)
Sigh, thanks.


================
Comment at: lld/test/ELF/gnu-ifunc-noplt.s:24
+// DISASM-NEXT: foo:
+// DISASM-NEXT:   201000:       c3      retq
+// DISASM:      bar:
----------------
MaskRay wrote:
> > // DISASM-NEXT:   201000:       c3      retq
> 
> I believe you are still using an older llvm-objdump
> After rL358474, you shall see
> 
> ```
> 0000000000001001 bar:
>     1001: c3                            retq
> 
> 0000000000001002 _start:
>     1002: e8 29 00 00 00                callq   41 <foo at plt>                                                   
>     1007: e8 34 00 00 00                callq   52 <bar at plt>
>     100c: e8 3f 00 00 00                callq   63 <bar2 at plt>
>     1011: e8 4a 00 00 00                callq   74 <zed2 at plt>
> ```
> 
> A better test should probably use `llvm-objdump --no-show-raw-insn` as the hex bytes here are not useful.
> 
> 
I see, sorry. I reformatted all of the output using an updated llvm-objdump and added --no-show-raw-insn.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61613/new/

https://reviews.llvm.org/D61613