[PATCH] D54367: RegAllocFast: Improve hinting heuristic

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Looks good to me, modulo the order in which we check the hints.



================
Comment at: lib/CodeGen/RegAllocFast.cpp:656
+      MRI->isAllocatable(Hint0) && RC.contains(Hint0) &&
+      !isRegUsedInInstr(Hint0)) {
+    // Ignore the hint if we would have to spill a dirty register.
----------------
I would rather we try the hint that we've been given first. (I.e., Hint1 before Hint0).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54367/new/

https://reviews.llvm.org/D54367