[PATCH] D61855: Simplify SymbolTable::add{Defined,Undefined,...} functions.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1379
+  Undefined Sym(nullptr, Name, STB_GLOBAL, STV_DEFAULT, 0);
+  return Symtab->addUndefined<ELFT>(&Sym);
 }
----------------
What was confusing for me when I saw this in your patch is that `Sym` is a pointer.
I.e. I was wondering can `addUndefined` store it somewhere inside or not. Should it be a reference may be?

And then you should be able to:

```
return Symtab->addUndefined<ELFT>({nullptr, Name, STB_GLOBAL, STV_DEFAULT, 0)});
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61855/new/

https://reviews.llvm.org/D61855