[PATCH] D61847: [lldb] modernize codebase with modernize-use-nullptr
Raphael Isemann via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 13 01:53:58 PDT 2019
teemperor added a reviewer: LLDB.
teemperor added inline comments.
================
Comment at: lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:76
static constexpr PropertyDefinition g_properties[] = {
- {"load-kexts", OptionValue::eTypeBoolean, true, true, NULL, {},
+ {"load-kexts",
+ OptionValue::eTypeBoolean,
----------------
Can you revert the auto-formatting here?
================
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:114
static constexpr PropertyDefinition g_properties[] = {
- {"packet-timeout", OptionValue::eTypeUInt64, true, 5
+ {"packet-timeout",
+ OptionValue::eTypeUInt64,
----------------
Can you revert the auto-formatting here (and in the next option definition)?
================
Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:603
public:
-
CommandObjectProcessMinidumpDump(CommandInterpreter &interpreter)
+ : CommandObjectParsed(interpreter, "process plugin dump",
----------------
Could you also revert the unrelated whitespace changes here? Phabricator doesn't really display the whitespace changes well, but this patch effectively reformats this whole INIT_BOOL chain (The reformatting itself is fine, but it should be it's own commit).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61847/new/
https://reviews.llvm.org/D61847
More information about the llvm-commits
mailing list