[PATCH] D60385: FileCheck [5/12]: Introduce regular numeric variables

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added a comment.

In D60385#1499819 <https://reviews.llvm.org/D60385#1499819>, @thopre wrote:

> In D60385#1499812 <https://reviews.llvm.org/D60385#1499812>, @jhenderson wrote:
>
> > Okay, LGTM, but make sure @probinson is happy at least.
>
>
> He wrote "I am pretty happy with this now, maybe give the other people who have been participating a day or so to chime in again" earlier so will commit this now. Thanks everyone who has tirelessly reviewed this patch! It's good to get the first big patch adding support for numeric expression landing.


FYI I've noticed the sphinx error in [1] and am investigated it. I changed laptop recently and sphinx build was not enabled on the new one which is why I missed it. Am doing a build now with sphinx enabled and will send a patch as soon as I can reproduce the issue.

[1] http://lab.llvm.org:8011/builders/llvm-sphinx-docs/builds/31133/steps/docs-llvm-html/logs/stdio


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60385/new/

https://reviews.llvm.org/D60385