[PATCH] D61710: lld: Add a warning limit, similar to the existing error limit

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 13 06:05:32 PDT 2019


grimar added inline comments.


================
Comment at: lld/Common/ErrorHandler.cpp:121
+
+  if (WarningLimit == 0 || WarningCount < WarningLimit) {
+    print("warning: ", raw_ostream::MAGENTA);
----------------
Should we have sokething like the following?

```
 if (WarningLimit > WarningLimit)
  continue;

print("warning: ", raw_ostream::MAGENTA);
if (WarningCount < WarningLimit)
  *ErrorOS << Msg << "\n";
else
  *ErrorOS << WarningLimitExceededMsg << "\n";
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61710/new/

https://reviews.llvm.org/D61710





More information about the llvm-commits mailing list