[PATCH] D61688: [LLD][ELF] Full support for -n (--nmagic) and -N (--omagic) via -zcommon-page-size

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 13 05:55:52 PDT 2019


grimar added inline comments.


================
Comment at: ELF/Driver.cpp:1221
+  if (!isPowerOf2_64(Val))
+    error("common-page-size: value isn't a power of 2");
+  if (Config->Nmagic || Config->Omagic) {
----------------
grimar wrote:
> I think we usually use dashes when mention a option name in error message.
i.e.

`error("--common-page-size......`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61688/new/

https://reviews.llvm.org/D61688





More information about the llvm-commits mailing list