[PATCH] D61306: [NFC] Refactor visitIntrinsicCall so it doesn't return a const char*

Mon May 13 04:59:01 PDT 2019

gchatelet marked an inline comment as done.
gchatelet added inline comments.

================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7542
+
   if (I.countOperandBundlesOfType(LLVMContext::OB_deopt))
     LowerCallSiteWithDeoptBundle(&I, Callee, nullptr);
----------------
gchatelet wrote:
> sanjoy wrote:
> > courbet wrote:
> > > So this is not really an NFC as this is is no longer executed on `setjmp`, `longjmp`, and `clear_cache`.  Here ends my knowledge, let's find reviewers who can comment on whether this is OK or not :)
> > This change in behavior seems fine to me but CC @reames to be sure. 
> Thx for the review @sanjoy . @reames do you mind having a look?
A gentle ping @reames 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61306/new/

https://reviews.llvm.org/D61306