[PATCH] D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA.

[Mikael Holmén via llvm-commits]

Hi,

On 5/12/19 4:50 PM, Alina Sbirlea wrote:
> Hi Mikael,
> 
> I don't seem to get this reproduced with the test and command you sent. 
> Is this still happening?
> 

Still happening, both when opt is compiled with clang and with gcc.

> Could you please file a PR and assign to me?
> 

Sure: https://bugs.llvm.org/show_bug.cgi?id=41853

> Please note I will be slow to answer due to traveling until Tuesday when 
> I'm back in the office.
> 

No worries.

Thanks,
Mikael

> Thanks,
> Alina
> 
> *From: *Mikael Holmén via Phabricator <reviews at reviews.llvm.org 
> <mailto:reviews at reviews.llvm.org>>
> *Date: *Fri, May 10, 2019 at 12:30 AM
> *To: * <asbirlea at google.com <mailto:asbirlea at google.com>>, 
> <chandlerc at gmail.com <mailto:chandlerc at gmail.com>>, 
> <george.burgess.iv at gmail.com <mailto:george.burgess.iv at gmail.com>>
> *Cc: * <mikael.holmen at ericsson.com <mailto:mikael.holmen at ericsson.com>>, 
> <nemanja.i.ibm at gmail.com <mailto:nemanja.i.ibm at gmail.com>>, 
> <jlebar at google.com <mailto:jlebar at google.com>>, <javed.absar at arm.com 
> <mailto:javed.absar at arm.com>>, <piotr.padlewski at gmail.com 
> <mailto:piotr.padlewski at gmail.com>>, <kit.barton at gmail.com 
> <mailto:kit.barton at gmail.com>>, <zhaoshiz at codeaurora.org 
> <mailto:zhaoshiz at codeaurora.org>>, <jji at us.ibm.com 
> <mailto:jji at us.ibm.com>>, <llvm-commits at lists.llvm.org 
> <mailto:llvm-commits at lists.llvm.org>>, <sanjoy at playingwithpointers.com 
> <mailto:sanjoy at playingwithpointers.com>>, <wmi at google.com 
> <mailto:wmi at google.com>>, <florian_hahn at apple.com 
> <mailto:florian_hahn at apple.com>>
> 
>     uabelho added a comment.
> 
>     When the assertion fails we have:
> 
>        (gdb) call F.dump()
> 
>        define void @loop_imm_reg_plus2() {
>          br i1 undef, label %bb5.preheader, label %bb3
> 
>        bb5.preheader:                                    ; preds = %0
>          br label %bb5
> 
>        bb5:                                              ; preds =
>     %bb5.preheader, %bb5
>          store i16 undef, i16* undef
>          br i1 false, label %bb5, label %bb3.loopexit
> 
>        bb3.loopexit:                                     ; preds = %bb5
>          br label %bb3
> 
>        bb3:                                              ; preds =
>     %bb3.loopexit, %0
>          ret void
>        }
> 
>        (gdb) call B.getName()
>        $11 = "bb5"
>        (gdb) call Phi->dump()
>        2 = MemoryPhi({%0,liveOnEntry},{bb5,1})
> 
> 
>     Repository:
>        rL LLVM
> 
>     CHANGES SINCE LAST ACTION
>     https://reviews.llvm.org/D60833/new/
> 
>     https://reviews.llvm.org/D60833
> 
> 
>