[PATCH] D61613: [LLD][ELF] Add the -z ifunc-noplt option

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 12 22:55:33 PDT 2019


MaskRay accepted this revision.
MaskRay added a comment.

LGTM



================
Comment at: lld/test/ELF/gnu-ifunc-noplt.s:24
+// DISASM-NEXT: foo:
+// DISASM-NEXT:   201000:       c3      retq
+// DISASM:      bar:
----------------
> // DISASM-NEXT:   201000:       c3      retq

I believe you are still using an older llvm-objdump
After rL358474, you shall see

```
0000000000001001 bar:
    1001: c3                            retq

0000000000001002 _start:
    1002: e8 29 00 00 00                callq   41 <foo at plt>                                                   
    1007: e8 34 00 00 00                callq   52 <bar at plt>
    100c: e8 3f 00 00 00                callq   63 <bar2 at plt>
    1011: e8 4a 00 00 00                callq   74 <zed2 at plt>
```

A better test should probably use `llvm-objdump --no-show-raw-insn` as the hex bytes here are not useful.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61613/new/

https://reviews.llvm.org/D61613





More information about the llvm-commits mailing list