[PATCH] D61831: [cmake] Do not generate benchmark targets by default

[Kirill Bobyrev via Phabricator via llvm-commits]

kbobyrev edited reviewers, added: ilya-biryukov, sammccall; removed: kbobyrev.
kbobyrev added a comment.

Hi @hintonda!

Could you please elaborate a bit on why you would like to propose this change? I couldn't understand the argument here:

> Since the benchmark subproject doesn't depend on llvm, there's not reason to generate its targets by default, i.e., there are no dependencies and changes to llvm can't break it.

>From my perspective, generating targets for benchmarks seems fine since it doesn't add it to `all` anyway and it is easier to build benchmarks. I would be interested to learn why you think this behavior is inconvenient.

Also

- If `LLVM_INCLUDE_BENCHMARKS` is set to `LLVM_BUILD_BENCHMARKS` then there's probably no reason in two variables.
- Changing the default value of CMake variable should be reflected in the LLVM's CMake docs since it explicitly mentions default value.

I might not have any time to review the patch soon, though :( I'm hoping that either Ilya or Sam can help with this change because we were discussing it before landing the original patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61831/new/

https://reviews.llvm.org/D61831