[PATCH] D61524: [BPF] Support for compile once and run everywhere

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 10 18:38:58 PDT 2019


efriedma added inline comments.


================
Comment at: lib/Target/BPF/BPFAbstrctMemberAccess.cpp:287
+
+  Instruction *ConstExprInst = ConstExpr->getAsInstruction();
+  auto *GEP = dyn_cast<GetElementPtrInst>(ConstExprInst);
----------------
getAsInstruction probably doesn't do what you want here.  It actually creates a new Instruction*, instead of casting the expression.  Probably this is the source of the verifier error.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61524/new/

https://reviews.llvm.org/D61524





More information about the llvm-commits mailing list