[lld] r360476 - [COFF] Update LLD yaml test cases to include .bss size

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Fri May 10 15:12:51 PDT 2019 

Author: rnk
Date: Fri May 10 15:12:51 2019
New Revision: 360476

URL: http://llvm.org/viewvc/llvm-project?rev=360476&view=rev
Log:
[COFF] Update LLD yaml test cases to include .bss size

These yaml test cases appear to have been affected by PR41836

Right now what happens is that these empty .bss sections are merged into
.data, then the .data output section ends up having a zero virtual size,
and it is discarded from the output after addresses are assigned.
However, we've already assigned OutputSections to Chunks, so we don't
correctly report the zero-sized chunks that were in there as having been
discarded. Soon, we will report them as discarded, so these test cases
need to be updated to have a non-zero size so they aren't discarded.

Modified:
    lld/trunk/test/COFF/Inputs/pdb-file-statics-a.yaml
    lld/trunk/test/COFF/Inputs/pdb-file-statics-b.yaml
    lld/trunk/test/COFF/Inputs/pdb-globals.yaml
    lld/trunk/test/COFF/Inputs/pdb_comdat_bar.yaml
    lld/trunk/test/COFF/pdb-comdat.test
    lld/trunk/test/COFF/sort-debug.test

Modified: lld/trunk/test/COFF/Inputs/pdb-file-statics-a.yaml
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/COFF/Inputs/pdb-file-statics-a.yaml?rev=360476&r1=360475&r2=360476&view=diff
==============================================================================
--- lld/trunk/test/COFF/Inputs/pdb-file-statics-a.yaml (original)
+++ lld/trunk/test/COFF/Inputs/pdb-file-statics-a.yaml Fri May 10 15:12:51 2019
@@ -1280,6 +1280,7 @@ sections:
     Characteristics: [ IMAGE_SCN_CNT_UNINITIALIZED_DATA, IMAGE_SCN_MEM_READ, IMAGE_SCN_MEM_WRITE ]
     Alignment:       4
     SectionData:     ''
+    SizeOfRawData:   4
   - Name:            '.text$mn'
     Characteristics: [ IMAGE_SCN_CNT_CODE, IMAGE_SCN_LNK_COMDAT, IMAGE_SCN_MEM_EXECUTE, IMAGE_SCN_MEM_READ ]
     Alignment:       4

Modified: lld/trunk/test/COFF/Inputs/pdb-file-statics-b.yaml
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/COFF/Inputs/pdb-file-statics-b.yaml?rev=360476&r1=360475&r2=360476&view=diff
==============================================================================
--- lld/trunk/test/COFF/Inputs/pdb-file-statics-b.yaml (original)
+++ lld/trunk/test/COFF/Inputs/pdb-file-statics-b.yaml Fri May 10 15:12:51 2019
@@ -1255,6 +1255,7 @@ sections:
     Characteristics: [ IMAGE_SCN_CNT_UNINITIALIZED_DATA, IMAGE_SCN_MEM_READ, IMAGE_SCN_MEM_WRITE ]
     Alignment:       4
     SectionData:     ''
+    SizeOfRawData:   4
   - Name:            '.text$mn'
     Characteristics: [ IMAGE_SCN_CNT_CODE, IMAGE_SCN_LNK_COMDAT, IMAGE_SCN_MEM_EXECUTE, IMAGE_SCN_MEM_READ ]
     Alignment:       4

Modified: lld/trunk/test/COFF/Inputs/pdb-globals.yaml
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/COFF/Inputs/pdb-globals.yaml?rev=360476&r1=360475&r2=360476&view=diff
==============================================================================
--- lld/trunk/test/COFF/Inputs/pdb-globals.yaml (original)
+++ lld/trunk/test/COFF/Inputs/pdb-globals.yaml Fri May 10 15:12:51 2019
@@ -70,6 +70,7 @@ sections:
     Characteristics: [ IMAGE_SCN_CNT_UNINITIALIZED_DATA, IMAGE_SCN_MEM_READ, IMAGE_SCN_MEM_WRITE ]
     Alignment:       4
     SectionData:     ''
+    SizeOfRawData:   4
   - Name:            .text
     Characteristics: [ IMAGE_SCN_CNT_CODE, IMAGE_SCN_LNK_COMDAT, IMAGE_SCN_MEM_EXECUTE, IMAGE_SCN_MEM_READ ]
     Alignment:       16
@@ -263,7 +264,6 @@ sections:
   - Name:            '.debug$T'
     Characteristics: [ IMAGE_SCN_CNT_INITIALIZED_DATA, IMAGE_SCN_MEM_DISCARDABLE, IMAGE_SCN_MEM_READ ]
     Alignment:       4
-    SectionData:     0400000006000112000000000E000810740000000000000000100000160001160000000001100000476C6F62616C46756E6300F10A000210700400000A8000000E0001120200000074000000031000000E0008107400000000000200041000001200011600000000051000006D61696E00F3F2F13200051500008002000000000000000000000000000048656C6C6F506F696E74002E3F415548656C6C6F506F696E74404000F2F1260003120D15030074000000000058000D15030074000000040059000D1503007400000008005A0032000515030000020810000000000000000000000C0048656C6C6F506F696E74002E3F415548656C6C6F506F696E74404000F2F13E00051600000000643A5C7372635C6C6C766D2D6D6F6E6F5C6C6C645C746573745C636F66665C696E707574735C7064622D676C6F62616C732E63707000F2F10E000616091000000A100000060000000A000210071000000A8000001A00091003000000071000000C1000000B000000001000000000000016000216071000000D10000048656C6C6F506F696E7400F11600011600000000011000004C6F63616C46756E6300F2F10A000110740000000100F2F10A000210101000000A800000
     Types:
       - Kind:            LF_ARGLIST
         ArgList:

Modified: lld/trunk/test/COFF/Inputs/pdb_comdat_bar.yaml
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/COFF/Inputs/pdb_comdat_bar.yaml?rev=360476&r1=360475&r2=360476&view=diff
==============================================================================
--- lld/trunk/test/COFF/Inputs/pdb_comdat_bar.yaml (original)
+++ lld/trunk/test/COFF/Inputs/pdb_comdat_bar.yaml Fri May 10 15:12:51 2019
@@ -190,6 +190,7 @@ sections:
     Characteristics: [ IMAGE_SCN_CNT_UNINITIALIZED_DATA, IMAGE_SCN_MEM_READ, IMAGE_SCN_MEM_WRITE ]
     Alignment:       4
     SectionData:     ''
+    SizeOfRawData:   4
   - Name:            '.text$mn'
     Characteristics: [ IMAGE_SCN_CNT_CODE, IMAGE_SCN_MEM_EXECUTE, IMAGE_SCN_MEM_READ ]
     Alignment:       16

Modified: lld/trunk/test/COFF/pdb-comdat.test
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/COFF/pdb-comdat.test?rev=360476&r1=360475&r2=360476&view=diff
==============================================================================
--- lld/trunk/test/COFF/pdb-comdat.test (original)
+++ lld/trunk/test/COFF/pdb-comdat.test Fri May 10 15:12:51 2019
@@ -48,9 +48,9 @@ CHECK-NEXT:             module = 2, sum
 CHECK-NEXT:       128 | S_PROCREF [size = 20] `foo`
 CHECK-NEXT:             module = 1, sum name = 0, offset = 208
 CHECK-NEXT:       104 | S_GDATA32 [size = 24] `global`
-CHECK-NEXT:             type = 0x0074 (int), addr = 0000:0000
+CHECK-NEXT:             type = 0x0074 (int), addr = 0003:0000
 CHECK-NEXT:       168 | S_GDATA32 [size = 24] `global`
-CHECK-NEXT:             type = 0x0074 (int), addr = 0000:0000
+CHECK-NEXT:             type = 0x0074 (int), addr = 0003:0000
 
 CHECK:                           Symbols
 CHECK: ============================================================

Modified: lld/trunk/test/COFF/sort-debug.test
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/COFF/sort-debug.test?rev=360476&r1=360475&r2=360476&view=diff
==============================================================================
--- lld/trunk/test/COFF/sort-debug.test (original)
+++ lld/trunk/test/COFF/sort-debug.test Fri May 10 15:12:51 2019
@@ -45,6 +45,7 @@ sections:
     Characteristics: [ IMAGE_SCN_CNT_UNINITIALIZED_DATA, IMAGE_SCN_MEM_READ, IMAGE_SCN_MEM_WRITE ]
     Alignment:       4
     SectionData:     ''
+    SizeOfRawData:   4
   - Name:            '.debug$S'
     Characteristics: [ IMAGE_SCN_CNT_INITIALIZED_DATA, IMAGE_SCN_MEM_DISCARDABLE, IMAGE_SCN_MEM_READ ]
     Alignment:       1

More information about the llvm-commits mailing list